Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump to v0.53.0 #5831

Merged
merged 2 commits into from
Apr 11, 2024
Merged

chore: bump to v0.53.0 #5831

merged 2 commits into from
Apr 11, 2024

Conversation

JoshuaBatty
Copy link
Member

@JoshuaBatty JoshuaBatty commented Apr 5, 2024

Description

Bump repo to 0.53.0

waiting on #5813

@JoshuaBatty JoshuaBatty marked this pull request as draft April 5, 2024 04:15
@JoshuaBatty JoshuaBatty self-assigned this Apr 5, 2024
Copy link

github-actions bot commented Apr 5, 2024

Benchmark for cefcbc7

Click to view benchmark
Test Base PR %
code_action 5.5±0.06ms 5.5±0.08ms 0.00%
code_lens 284.4±7.51ns 335.0±11.27ns +17.79%
compile 6.1±0.11s 6.0±0.14s -1.64%
completion 5.0±0.18ms 5.1±0.19ms +2.00%
did_change_with_caching 5.5±0.06s 5.5±0.04s 0.00%
document_symbol 951.3±15.54µs 1009.1±45.51µs +6.08%
format 71.7±1.12ms 77.4±1.31ms +7.95%
goto_definition 371.9±6.86µs 370.5±8.73µs -0.38%
highlight 9.2±0.05ms 9.2±0.21ms 0.00%
hover 606.8±19.80µs 610.9±18.67µs +0.68%
idents_at_position 122.4±0.59µs 123.2±1.22µs +0.65%
inlay_hints 670.0±11.29µs 670.2±28.58µs +0.03%
on_enter 494.6±15.41ns 484.0±16.91ns -2.14%
parent_decl_at_position 3.8±0.02ms 3.7±0.04ms -2.63%
prepare_rename 362.1±3.71µs 370.2±4.11µs +2.24%
rename 9.7±0.17ms 9.7±0.20ms 0.00%
semantic_tokens 1055.9±26.46µs 1060.5±11.42µs +0.44%
token_at_position 358.0±2.71µs 358.8±1.74µs +0.22%
tokens_at_position 3.8±0.14ms 3.7±0.04ms -2.63%
tokens_for_file 413.2±2.38µs 411.0±3.94µs -0.53%
traverse 44.5±1.60ms 45.1±1.28ms +1.35%

@IGI-111
Copy link
Contributor

IGI-111 commented Apr 8, 2024

Fair warning: if #5824 gets merged first, this would have to be a major.

Copy link
Member

@kayagokalp kayagokalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting change to block this from getting merged accidentally as #5824 got merged and this will need to become 0.53

@JoshuaBatty JoshuaBatty changed the title chore: bump to v0.52.2 chore: bump to v0.53.0 Apr 10, 2024
Copy link

Benchmark for bd5b6d6

Click to view benchmark
Test Base PR %
code_action 5.7±0.32ms 5.5±0.03ms -3.51%
code_lens 288.5±8.33ns 294.9±16.58ns +2.22%
compile 6.7±0.14s 6.5±0.08s -2.99%
completion 5.0±0.07ms 5.0±0.10ms 0.00%
did_change_with_caching 6.3±0.09s 6.3±0.03s 0.00%
document_symbol 937.1±10.99µs 1002.2±39.85µs +6.95%
format 76.8±1.33ms 76.9±2.87ms +0.13%
goto_definition 366.1±7.71µs 369.8±13.30µs +1.01%
highlight 9.1±0.09ms 9.1±0.14ms 0.00%
hover 608.4±12.30µs 649.9±21.39µs +6.82%
idents_at_position 122.6±1.76µs 124.2±0.95µs +1.31%
inlay_hints 667.5±27.56µs 684.6±46.96µs +2.56%
on_enter 492.5±13.32ns 513.2±27.19ns +4.20%
parent_decl_at_position 3.7±0.03ms 3.8±0.03ms +2.70%
prepare_rename 367.3±8.75µs 366.9±8.10µs -0.11%
rename 9.8±0.27ms 9.7±0.53ms -1.02%
semantic_tokens 1042.3±20.12µs 1072.5±12.11µs +2.90%
token_at_position 362.6±4.53µs 419.7±2.11µs +15.75%
tokens_at_position 3.7±0.03ms 3.8±0.03ms +2.70%
tokens_for_file 406.6±3.00µs 417.6±2.08µs +2.71%
traverse 49.4±1.67ms 49.5±1.72ms +0.20%

Copy link
Member

@kayagokalp kayagokalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving to unblock

@IGI-111 IGI-111 marked this pull request as ready for review April 11, 2024 10:52
@IGI-111 IGI-111 enabled auto-merge (squash) April 11, 2024 10:52
@IGI-111 IGI-111 merged commit b30f0e8 into master Apr 11, 2024
38 checks passed
@IGI-111 IGI-111 deleted the josh/bump-0.52.2 branch April 11, 2024 11:15
Copy link

Benchmark for 136764b

Click to view benchmark
Test Base PR %
code_action 5.6±0.11ms 5.6±0.12ms 0.00%
code_lens 288.6±4.78ns 290.5±8.57ns +0.66%
compile 6.1±0.07s 6.2±0.13s +1.64%
completion 5.1±0.13ms 5.0±0.11ms -1.96%
did_change_with_caching 6.0±0.07s 6.1±0.06s +1.67%
document_symbol 1009.7±48.84µs 954.1±31.44µs -5.51%
format 76.6±1.15ms 79.6±1.25ms +3.92%
goto_definition 357.4±6.27µs 367.9±10.50µs +2.94%
highlight 9.2±0.09ms 9.2±0.14ms 0.00%
hover 616.3±20.98µs 597.7±19.28µs -3.02%
idents_at_position 124.1±0.79µs 123.7±1.25µs -0.32%
inlay_hints 658.5±7.49µs 664.3±22.90µs +0.88%
on_enter 497.8±17.80ns 510.5±15.88ns +2.55%
parent_decl_at_position 3.7±0.04ms 3.8±0.04ms +2.70%
prepare_rename 354.9±6.07µs 370.6±6.05µs +4.42%
rename 9.8±0.19ms 9.7±0.27ms -1.02%
semantic_tokens 1017.2±12.42µs 1066.4±45.66µs +4.84%
token_at_position 350.8±3.03µs 358.4±5.21µs +2.17%
tokens_at_position 3.7±0.03ms 3.8±0.03ms +2.70%
tokens_for_file 420.3±2.03µs 421.3±2.01µs +0.24%
traverse 49.2±1.88ms 50.8±2.43ms +3.25%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants