Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbiDecode for Vec using with_capacity #5849

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Apr 12, 2024

Description

This PR uses the fact that we know the final length of the Vec, and creates it with the correct length, avoiding future allocations.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@xunilrj xunilrj changed the title Xunilrj/abi decode vec with capacity AbiDecode for Vec using with_capacity Apr 12, 2024
@IGI-111 IGI-111 requested a review from a team April 12, 2024 14:21
@IGI-111 IGI-111 enabled auto-merge (squash) April 12, 2024 14:32
@IGI-111 IGI-111 merged commit 2d73d09 into master Apr 12, 2024
31 of 32 checks passed
@IGI-111 IGI-111 deleted the xunilrj/abi-decode-vec-with-capacity branch April 12, 2024 14:56
@danielbate danielbate restored the xunilrj/abi-decode-vec-with-capacity branch April 12, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants