Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor read and write access to namespace modules. #5868

Merged
merged 5 commits into from
Apr 19, 2024

Conversation

tritao
Copy link
Contributor

@tritao tritao commented Apr 17, 2024

Description

This PR prepares existing code that deals with (mutable) access to namespace modules to work with an upcoming PR that introduces a module ID for optimization purposes.

It also refactors the ABI code to pass engines around, which is necessary for the same PR.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@tritao tritao self-assigned this Apr 17, 2024
@tritao tritao marked this pull request as ready for review April 18, 2024 08:36
@tritao tritao requested a review from kayagokalp as a code owner April 18, 2024 08:36
@tritao tritao requested a review from a team April 18, 2024 08:36
Copy link
Contributor

@jjcnn jjcnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tritao tritao merged commit e8e6d3a into FuelLabs:master Apr 19, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants