New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add call_with_function_selector
version for new encoding
#5869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hal3e
added
lib: std
Standard library
breaking
May cause existing user code to break. Requires a minor or major release.
labels
Apr 17, 2024
xunilrj
previously approved these changes
Apr 18, 2024
jjcnn
previously approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
xunilrj
approved these changes
Apr 18, 2024
jjcnn
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
call_with_function_selector
compatible with the new encoding.create_payload
compatible with the new encoding.contract_id_to_bytes
.call_with_function_selector_vec
and corresponding tests.low_level_call_bytes
test project tolow_level_call
.relevant issue: #5727
BREAKING CHANGE: Removed
call_with_function_selector_vec
Checklist
Breaking*
orNew Feature
labels where relevant.