Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add call_with_function_selector version for new encoding #5869

Merged
merged 11 commits into from Apr 19, 2024

Conversation

hal3e
Copy link
Contributor

@hal3e hal3e commented Apr 17, 2024

Description

  • Added a version of call_with_function_selector compatible with the new encoding.
  • Added a version of create_payload compatible with the new encoding.
  • Removed contract_id_to_bytes.
  • Removed call_with_function_selector_vec and corresponding tests.
  • Rename low_level_call_bytes test project to low_level_call.

relevant issue: #5727

BREAKING CHANGE: Removed call_with_function_selector_vec

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@hal3e hal3e added lib: std Standard library breaking May cause existing user code to break. Requires a minor or major release. labels Apr 17, 2024
@hal3e hal3e requested a review from xunilrj April 17, 2024 12:29
@hal3e hal3e self-assigned this Apr 17, 2024
xunilrj
xunilrj previously approved these changes Apr 18, 2024
jjcnn
jjcnn previously approved these changes Apr 18, 2024
Copy link
Contributor

@jjcnn jjcnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IGI-111 IGI-111 enabled auto-merge (squash) April 18, 2024 08:42
@hal3e hal3e dismissed stale reviews from jjcnn and xunilrj via ebc9587 April 18, 2024 08:45
@hal3e hal3e disabled auto-merge April 18, 2024 08:45
@hal3e hal3e requested a review from jjcnn April 18, 2024 15:03
@hal3e hal3e merged commit a5b1b55 into master Apr 19, 2024
35 checks passed
@hal3e hal3e deleted the hal3e/call_with_fn_selector branch April 19, 2024 11:41
@hal3e hal3e restored the hal3e/call_with_fn_selector branch April 19, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking May cause existing user code to break. Requires a minor or major release. lib: std Standard library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants