Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Wallet Example Clarification #5878

Merged
merged 7 commits into from Apr 19, 2024

Conversation

calldelegation
Copy link
Contributor

@calldelegation calldelegation commented Apr 18, 2024

Description

https://forum.fuel.network/t/module-wallet-abi-could-not-be-found/5116
Nick asked for clarification in the wallet example based on this inquiry in the forum.

TLDR:
It is unclear to the user that, when copying the example into their own Sway project, these are two separate projects and require a dependency declaration inside the forc.toml file.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@calldelegation calldelegation self-assigned this Apr 18, 2024
@calldelegation calldelegation removed the request for review from bitzoic April 18, 2024 21:10
@calldelegation calldelegation marked this pull request as draft April 18, 2024 21:10
@calldelegation calldelegation requested review from bitzoic and a team April 19, 2024 03:06
@calldelegation calldelegation marked this pull request as ready for review April 19, 2024 03:07
@calldelegation calldelegation enabled auto-merge (squash) April 19, 2024 14:31
@calldelegation calldelegation merged commit e12d985 into master Apr 19, 2024
36 checks passed
@calldelegation calldelegation deleted the doc/wallet-example-clarification branch April 19, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants