Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conversion methods for u256,b256 from tuple of u64s #5889

Merged
merged 11 commits into from
Apr 29, 2024

Conversation

SwayStar123
Copy link
Member

Description

Adds impl From<(u64, u64, u64, u64)> for u256, b256

Closes #5820

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@SwayStar123 SwayStar123 added enhancement New feature or request lib: std Standard library labels Apr 22, 2024
@SwayStar123 SwayStar123 self-assigned this Apr 22, 2024
@SwayStar123 SwayStar123 enabled auto-merge (squash) April 24, 2024 15:42
bitzoic
bitzoic previously approved these changes Apr 25, 2024
@xunilrj
Copy link
Contributor

xunilrj commented Apr 25, 2024

My problem with this kind of conversions is endianess. As it is never clear which convention is being used and we always need to end up reading documentation.

Why not simple named conversions? Like from_be_words, from_le_words etc... or anything similar.

Also, it may also make sense to convert from and into arrays.

@SwayStar123
Copy link
Member Author

My problem with this kind of conversions is endianess. As it is never clear which convention is being used and we always need to end up reading documentation.

Why not simple named conversions? Like from_be_words, from_le_words etc... or anything similar.

Also, it may also make sense to convert from and into arrays.

There are already array conversions for both endians in the std lib for u16, u32, u64, b256 and u256

@SwayStar123 SwayStar123 merged commit 2abe941 into master Apr 29, 2024
33 checks passed
@SwayStar123 SwayStar123 deleted the u256b256fromu64x4 branch April 29, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lib: std Standard library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing u256 From implementation
5 participants