Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds test that proves unexpected error no longer occcurs. #5910

Merged
merged 2 commits into from Apr 24, 2024

Conversation

esdrubal
Copy link
Contributor

@esdrubal esdrubal commented Apr 23, 2024

Description

The issue reported in #4689 is already fixed.
This PR only adds a test to prove it works as expected.

Closes #4689.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

The issue reported in #4689 is already fixed.
This PR only adds a test to prove it works as expected.

Closes #4689.
@esdrubal esdrubal added bug Something isn't working compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen labels Apr 23, 2024
@esdrubal esdrubal self-assigned this Apr 23, 2024
@esdrubal esdrubal requested a review from a team April 23, 2024 15:42
@esdrubal esdrubal marked this pull request as ready for review April 23, 2024 15:42
@IGI-111 IGI-111 merged commit dd0e9a0 into master Apr 24, 2024
35 checks passed
@IGI-111 IGI-111 deleted the esdrubal/4689_compile_error_in_struct_instantiation branch April 24, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compile error in struct instantiation
4 participants