set new encoding as true by default and allow it to be disabled #5915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IGI-111
previously approved these changes
Apr 24, 2024
Benchmark for a83a6c1Click to view benchmark
|
Benchmark for ac40cefClick to view benchmark
|
Benchmark for 4376fd2Click to view benchmark
|
Benchmark for 1b8b509Click to view benchmark
|
Benchmark for 29d3e04Click to view benchmark
|
Benchmark for 93586b5Click to view benchmark
|
Benchmark for 2c84f6bClick to view benchmark
|
Benchmark for 6bf171bClick to view benchmark
|
Benchmark for b9f4f5eClick to view benchmark
|
Benchmark for 31e109fClick to view benchmark
|
Benchmark for 67fb952Click to view benchmark
|
Benchmark for e9876adClick to view benchmark
|
xunilrj
force-pushed
the
xunilrj/flip-new-encoding-flag
branch
from
11ef06d
to
e92de2f
Compare
Benchmark for 7e3f1ffClick to view benchmark
|
IGI-111
approved these changes
Apr 25, 2024
Voxelot
approved these changes
Apr 25, 2024
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR sets the "new encoding" (from now on will be called "encoding v1") as the default. We can still disable it using
no_encoding_v1, which switches back to "encoding v0".Actions that needs to be done after this being merged will exist in #5727
New features
Bugs Fixed
ContractCallintrinsic interaction effect was not set correctly;Fixing warnings and error messages
Never. This means it does not realize it is impossible to call two contract functions;Test Disabled (needs to be enabled again in the future)
Test generating more warnings than before
What happens here is that when we implement a trait for
Contract, we actually generate two functions: one prefixed__contract_entrythat is called by the method selector; and another one normal, that can be called freely. So, if the trait method is never called manually, it is marked as dead.I actually think the new warning is correct and nothing here needs to be done.
Test with fewer warnings than before
auto-impl is making all fields being used. so no dead code warnings are being generated. We need to fix this.
Changes to std-lib
first_paramandsecond_paramreturn the value as the VM sees them. We now havecalled_methodandcalled_args. This means that we can change the protocol later and still keep these four functions always working and with meaningful names.ICE
Buffer. For some reason, it is generating an ICE. I need to create an issue so we can fix, and improve the implementation here.Bufferused by AbiEncode needs apush_bytesso we can be more efficient when encoding Bytes and others.Checklist
Breaking*orNew Featurelabels where relevant.