Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non idiomatic function names warnings in the std lib. #5949

Merged
merged 3 commits into from May 6, 2024

Conversation

tritao
Copy link
Contributor

@tritao tritao commented May 2, 2024

warning
   --> sway-lib-std/src/primitive_conversions/u64.sw:189:4
    |
187 |
188 | #[test]
189 | fn test_u64_try_from_U128() {
|    ---------------------- Function name "test_u64_try_from_U128"
is not idiomatic. Function names should be snake_case, like
"test_u64_try_from_u128".
190 |     use ::assert::assert;
    |

Description

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

```
warning
   --> sway-lib-std/src/primitive_conversions/u64.sw:189:4
    |
187 |
188 | #[test]
189 | fn test_u64_try_from_U128() {
|    ---------------------- Function name "test_u64_try_from_U128"
is not idiomatic. Function names should be snake_case, like
"test_u64_try_from_u128".
190 |     use ::assert::assert;
    |
```
@tritao tritao added lib: std Standard library code quality labels May 2, 2024
@tritao tritao requested a review from SwayStar123 May 2, 2024 15:56
@tritao tritao self-assigned this May 2, 2024
@tritao tritao changed the title Fix warning about non idiomatic function names in the std lib. Fix non idiomatic function names warnings in the std lib. May 2, 2024
@tritao tritao marked this pull request as ready for review May 2, 2024 17:13
@tritao tritao requested review from a team May 2, 2024 17:13
@JoshuaBatty JoshuaBatty requested review from a team May 3, 2024 00:33
Copy link
Contributor

@IGI-111 IGI-111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are tests, so it's fine, but if these were actually part of the std interface I'd want to maintain the capitalization. We may have builtin u128 at some point in the future.

@IGI-111 IGI-111 enabled auto-merge (squash) May 6, 2024 02:23
@IGI-111 IGI-111 merged commit 76beb04 into FuelLabs:master May 6, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality lib: std Standard library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants