Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inline docs example for From<T> for b256 implementations for ContractId, AssetId, Address, and EvmAddress #5970

Merged
merged 4 commits into from
May 8, 2024

Conversation

bitzoic
Copy link
Member

@bitzoic bitzoic commented May 7, 2024

Description

Because the examples were missing a type annotation they would not compile if a user attempted to use the example.

EvmAddress did not have any docs so these were added

Closes #5969

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@bitzoic bitzoic added bug Something isn't working lib: std Standard library documentation labels May 7, 2024
@bitzoic bitzoic self-assigned this May 7, 2024
@bitzoic bitzoic linked an issue May 7, 2024 that may be closed by this pull request
@bitzoic bitzoic changed the title Fix inline docs example for From<b256> implementations for ContractId, AssetId, and Address Fix inline docs example for From<T> for b256 implementations for ContractId, AssetId, and Address May 7, 2024
@bitzoic bitzoic requested a review from a team May 7, 2024 06:04
@bitzoic bitzoic changed the title Fix inline docs example for From<T> for b256 implementations for ContractId, AssetId, and Address Fix inline docs example for From<T> for b256 implementations for ContractId, AssetId, Address, and EvmAddress May 7, 2024
@bitzoic bitzoic merged commit 1cdb9a5 into master May 8, 2024
36 checks passed
@bitzoic bitzoic deleted the bitzoic-5969 branch May 8, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation lib: std Standard library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Into implementation example for ContractId and Address
3 participants