Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor forc-doc into a lib and add tests folder #5971

Merged
merged 10 commits into from
May 9, 2024

Conversation

JoshuaBatty
Copy link
Member

Description

Just some cleaning up to make it easier to have a dedicated tests folder with specific sway project fixtures. Similar to how sway-lsp is set up.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@JoshuaBatty JoshuaBatty self-assigned this May 7, 2024
@JoshuaBatty JoshuaBatty added code quality forc-doc Everything related to the `forc doc` command plugin. labels May 7, 2024
@JoshuaBatty JoshuaBatty requested review from a team May 7, 2024 06:37
tritao
tritao previously approved these changes May 7, 2024
@tritao tritao requested a review from a team May 7, 2024 08:04
@JoshuaBatty JoshuaBatty marked this pull request as draft May 7, 2024 10:01
@JoshuaBatty JoshuaBatty force-pushed the josh/refactor_into_lib branch 2 times, most recently from bd9787c to 43d0972 Compare May 8, 2024 02:27
@JoshuaBatty JoshuaBatty marked this pull request as ready for review May 8, 2024 03:14
@JoshuaBatty JoshuaBatty requested a review from tritao May 8, 2024 03:14
@JoshuaBatty JoshuaBatty enabled auto-merge (squash) May 8, 2024 06:13
@JoshuaBatty JoshuaBatty requested a review from a team May 8, 2024 11:39
@JoshuaBatty JoshuaBatty merged commit 0c09470 into master May 9, 2024
34 checks passed
@JoshuaBatty JoshuaBatty deleted the josh/refactor_into_lib branch May 9, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality forc-doc Everything related to the `forc doc` command plugin.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants