feat: fee estimation for forc-deploy and point --testnet to devnet #5990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
kayagokalp
commented
May 13, 2024
kayagokalp
added
enhancement
|
Requesting compiler review as well as this is blocking the release. |
Abstracts the current "--testnet" network further so we don't need to update it in so many places. Also gets the faucet URL from the network from chain_info rather than always using the testnet faucet URL.
sdankel
approved these changes
May 13, 2024
Voxelot
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Estimation is hard to test as it is dependent on the network configuration but this is nearly the same thing we have been doing for scripts.
--testnetpoints to devnet.max_feerequirement, adds an estimation phase with dry runing the transactionMost visible outcome is that
forc-deploy --testnetcan deploy to devnet without any other flags etc.