You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we have the ability to cache programs and also clear these programs from the engines using a garbage collector. The current terminology refers to modules rather than programs. I want to implement more granular caching and GC at the module level rather than just at the program level. This helps clear up what is actually being cached and cleared from the GC.
Checklist
I have linked to any relevant issues.
I have commented my code, particularly in hard-to-understand areas.
I have updated the documentation where relevant (API docs, the reference, and the Sway book).
Does program mean package, as in 1 program per Forc manifest file? And there can be multiple modules (sway files) per program?
This looks good, but I was wondering the same here. My initial thought was that we would be using Package level caching for this, but Program also seems ok. Still think it would be helpful to address this somehow, as it can get confusing, maybe by documenting what each layer of caching means.
@tritao and @sdankel yeah you're both correct, There is a second terminology refactor that needs to take place to sync the compiler and forc terminology here. I think package over program is the correct choice here personally.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently we have the ability to cache programs and also clear these programs from the engines using a garbage collector. The current terminology refers to modules rather than programs. I want to implement more granular caching and GC at the module level rather than just at the program level. This helps clear up what is actually being cached and cleared from the GC.
Checklist
Breaking*
orNew Feature
labels where relevant.