Refactor trait handling when doing namespace item imports. #6080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tritao
added
compiler: frontend
tritao
force-pushed
the
refactor-trait-handling-item-import
branch
from
b1f2604
to
ed8ee9c
Compare
IGI-111
approved these changes
May 31, 2024
JoshuaBatty
reviewed
Jun 1, 2024
JoshuaBatty
approved these changes
Jun 1, 2024
tritao
added a commit
to tritao/sway
that referenced
this pull request
Jun 25, 2024
This reverts PR FuelLabs#6080 due to a pretty severe performance regression. The reason this was split to a separate step was because it needs a typed declaration due to the depedency on the type system and thus cannot be used during collection. However, the type system will be changed to work with parsed declarations pretty soon, so revert this back to the old behavior and temporarily check for a typed declaration instead. Fixes FuelLabs#6182.
8 tasks
tritao
added a commit
to tritao/sway
that referenced
this pull request
Jun 25, 2024
This reverts PR FuelLabs#6080 due to a pretty severe performance regression. The reason this was split to a separate step was because it needs a typed declaration due to the depedency on the type system and thus cannot be used during collection. However, the type system will be changed to work with parsed declarations pretty soon, so revert this back to the old behavior and temporarily check for a typed declaration instead. Fixes FuelLabs#6182.
JoshuaBatty
added a commit
that referenced
this pull request
Jun 26, 2024
This reverts PR #6080 due to a pretty severe performance regression. The reason this was split to a separate step was because it needs a typed declaration due to the depedency on the type system and thus cannot be used during collection. However, the type system will be changed to work with parsed declarations pretty soon, so revert this back to the old behavior and temporarily check for a typed declaration instead. Fixes #6182. ## Description ## Checklist - [ ] I have linked to any relevant issues. - [ ] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] If my change requires substantial documentation changes, I have [requested support from the DevRel team](https://github.com/FuelLabs/devrel-requests/issues/new/choose) - [ ] I have added tests that prove my fix is effective or that my feature works. - [ ] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers. Co-authored-by: Joshua Batty <joshpbatty@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This splits off trait handling when doing namespace item imports to be done as a separate step.
Instead of doing it as we build the import tree, we now do it at a later stage.
This process requires a fully typed tree, which is not available when doing imports for a parsed declaration tree.
Checklist
Breaking*orNew Featurelabels where relevant.