-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use immediates instead of data section when possible #6098
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for 0bdefa2Click to view benchmark
|
Benchmark for 6f2f357Click to view benchmark
|
Benchmark for 2b30bb5Click to view benchmark
|
Benchmark for e90da9fClick to view benchmark
|
Benchmark for d256a35Click to view benchmark
|
Benchmark for 3f9d7e2Click to view benchmark
|
IGI-111
previously approved these changes
Jun 11, 2024
Benchmark for 9f34a51Click to view benchmark
|
Benchmark for 87b4660Click to view benchmark
|
Benchmark for 36ecedeClick to view benchmark
|
This comment was marked as spam.
This comment was marked as spam.
Benchmark for 606deffClick to view benchmark
|
IGI-111
approved these changes
Jun 13, 2024
xunilrj
approved these changes
Jun 14, 2024
Benchmark for 8c68eebClick to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading / initialising constants from the data section is unnecessary (takes up a data section slot) when the constant can instead, just be moved to a register using
MOVi
, if the constant can fit as an immediate value to the instruction.