Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove Forc.lock files from template projects #6101

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

sdankel
Copy link
Member

@sdankel sdankel commented Jun 7, 2024

Description

These projects are used as templates in forc template and having the lock files as part of the template could cause issues. The lock file should be generated on the fly by forc.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@sdankel sdankel marked this pull request as ready for review June 7, 2024 18:26
@sdankel sdankel requested review from a team as code owners June 7, 2024 18:26
Voxelot
Voxelot previously approved these changes Jun 7, 2024
kayagokalp
kayagokalp previously approved these changes Jun 7, 2024
@sdankel sdankel dismissed stale reviews from kayagokalp and Voxelot via 741dd9c June 7, 2024 18:56
@sdankel sdankel enabled auto-merge (squash) June 7, 2024 19:09
@sdankel sdankel merged commit 3f99163 into master Jun 7, 2024
41 checks passed
@sdankel sdankel deleted the sophie/rm-template-example-forclock branch June 7, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants