This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Add balance validation when creating new pull #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuizAsFight
added
bug
luizstacio
suggested changes
May 18, 2022
client/src/pages/PoolPage.tsx
Outdated
| const fromInput = useCoinInput({ | ||
| coin: coinFrom, | ||
| coins: getOtherCoins([coinFrom, coinTo]), | ||
| onChangeCoin: (coin: Coin) => setCoins([coin, coinTo]), | ||
| coinBalance: fromCoinBalance |
There was a problem hiding this comment.
You don't need to pass this here, just use the inside functions of the component
There was a problem hiding this comment.
coinBalance is needed to know wallet balance
luizstacio
approved these changes
May 18, 2022
LuizAsFight
added a commit
that referenced
this pull request
May 19, 2022
This was
linked to
issues
May 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Balanceinformation over Coin Selector.Maxbutton to put balance value in the input.Confirmbutton, disabling it and including balance feedback when neededScreen.Recording.2022-05-18.at.17.58.08.mov