Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

feat: add wallet on header and create two pages, assets and create wallet #162

Merged
merged 14 commits into from May 20, 2022
Merged

feat: add wallet on header and create two pages, assets and create wallet #162

merged 14 commits into from May 20, 2022

Conversation

pedronauck
Copy link
Member

@pedronauck pedronauck commented May 20, 2022 •
edited

✨ Fix #127

Kapture 2022-05-19 at 23 36 47

Tasks

  • Remove wallet page as index route
  • Create a new page called CreateWallet
  • Add a new page called Assets
  • Add wallet information on header
  • Remove unused FaucetPage

@pedronauck pedronauck added the feature New features that need to be implemented label May 20, 2022
@pedronauck pedronauck self-assigned this May 20, 2022
luizstacio
luizstacio suggested changes May 20, 2022
View reviewed changes
packages/app/src/AppRoutes.tsx Outdated Show resolved Hide resolved
packages/app/src/AppRoutes.tsx Outdated Show resolved Hide resolved
packages/app/src/layouts/MainLayout.tsx Outdated Show resolved Hide resolved
packages/app/src/pages/CreateWallet.tsx Outdated Show resolved Hide resolved
packages/app/src/pages/WalletPage.tsx Show resolved Hide resolved
@pedronauck
Copy link
Member Author

talked with @luizstacio and we will remove assets page and add it as a popover when click on wallet at topbar

@kallemoen
Copy link

@pedronauck This is a nice upgrade, I chatted with Luiz and we came up with an idea we wanted to share for how we can improve this even further: https://capture.dropbox.com/xTtjGXUM4b7m5Y9h

I made a little video explaining the idea above. Let me know if you have any questions :)

@vercel
Copy link

vercel bot commented May 20, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
swayswap ✅ Ready (Inspect) Visit Preview May 20, 2022 at 6:28PM (UTC)

@pedronauck
Copy link
Member Author

pedronauck commented May 20, 2022 •
edited

cool @kallemoen file is still uploading, in fact, I did some changes already, I didn't see your comment here and I was already working (because I did a call with @luizstacio also earlier haha) and that's the result of my changes:

Kapture 2022-05-20 at 15 02 08

@pedronauck
Merge branch 'master' of github.com:FuelLabs/swayswap into feat/walle…
c7272fe 
…t-topnav

* 'master' of github.com:FuelLabs/swayswap:
  refac: add skeleton as loading (#168)
  docs: info for env variables and setup (#170)
  docs: update READMEs with getting started and project structure info (#167)
  refac: remove recoil and use jotai (#166)
@pedronauck pedronauck merged commit 94a1c31 into master May 20, 2022
@pedronauck pedronauck deleted the feat/wallet-topnav branch May 20, 2022 20:54
@kallemoen
Copy link

@pedronauck

Sorry about that, I closed my computer before it had loaded. Just reviewed the work you did, and you can ignore the last video. I've written up my new feedback below.

  • Welcome page
    • Use this new copy
      • HEADLINE: Welcome to SwaySwap
      • SUB-TEXT: To get started you'll need a wallet, click below to generate one.
      • BUTTON: Create wallet
    • When someone clicks the "Create wallet" button, the UI should act accordingly:
      • Redirect you to the main app page
      • Open the wallet tab to an open state so you can see your wallet
      • Automatically call the faucet function
      • Show success messages for wallet creation and faucet
  • Faucet and Mint dropdown
    • I don't think this should exist inside the wallet at all. Instead create a button in the bottom left corner of the app that says "Faucet & Minting".
    • When you click it, it should open up a modal that has the following content:
      • Headline: Faucet
      • Description: Click the button below to mint 0.5 ETH to your wallet.
      • Button: Give me eth
      • -- divider --
      • Headline: Mint
      • Description: Mint new token types for testing purposes by adding the contract Id and amount below.
      • Input: 0xb72c566e5a9f69c98298a04d70a38cb32baca4d9b280da8590e0314fb00c59e0
      • Amount to mint: 2000
      • Button: Mint tokens

@kallemoen
Copy link

@pedronauck Also, we need to fix the layout on mobile for the wallet. Let's try to make the layout something close to this on mobile:
Screenshot 2022-05-22 at 12 55 03

@luizstacio luizstacio mentioned this pull request May 22, 2022
Closed
@kallemoen kallemoen mentioned this pull request May 24, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@luizstacio luizstacio luizstacio approved these changes

Assignees

@pedronauck pedronauck

Labels
feature New features that need to be implemented
Projects
Fuel Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add wallet integration/view on Topbar
3 participants
@pedronauck @kallemoen @luizstacio