Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

feat: add user guided states on swap #188

Merged
merged 3 commits into from May 23, 2022
Merged

feat: add user guided states on swap #188

merged 3 commits into from May 23, 2022

Conversation

luizstacio
Copy link
Member

@luizstacio luizstacio commented May 21, 2022 •
edited

@luizstacio luizstacio self-assigned this May 21, 2022
@vercel
Copy link

vercel bot commented May 21, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
swayswap ✅ Ready (Inspect) Visit Preview May 23, 2022 at 5:44PM (UTC)

@luizstacio luizstacio linked an issue May 21, 2022 that may be closed by this pull request
Add user guide states on swap #132
Closed
6 tasks
@luizstacio luizstacio linked an issue May 21, 2022 that may be closed by this pull request
On swap when inverting values its showing insufficient liquidity #131
Closed
@LuizAsFight
Copy link
Contributor

When changing to amount (DAI), it should not validate the balance. I think for a swap only from balance should be validated

Screen.Recording.2022-05-23.at.14.01.58.mov

@LuizAsFight
Copy link
Contributor

@luizstacio what's the use case to get the Insufficient liquidity feedback ?

@luizstacio
Copy link
Member Author

@luizstacio what's the use case to get the Insufficient liquidity feedback ?

You need to ask for one amount bigger them the reserves

@LuizAsFight
Copy link
Contributor

@luizstacio also created a issue related to this page/behavior

#192

LuizAsFight
LuizAsFight suggested changes May 23, 2022
View reviewed changes
Copy link
Contributor

@LuizAsFight LuizAsFight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bug with to balance amount validation still not fixed.

LuizAsFight
LuizAsFight approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@LuizAsFight LuizAsFight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luizstacio luizstacio merged commit 2277e6b into master May 23, 2022
@luizstacio luizstacio deleted the ls/feat-states-swap branch May 23, 2022 17:54
pedronauck added a commit that referenced this pull request May 23, 2022
@pedronauck
Merge branch 'master' of github.com:FuelLabs/swayswap into feat/token…
cc5c145 
…-select

* 'master' of github.com:FuelLabs/swayswap:
  ci: add action for validate pull request (#178)
  feat: add user guided states on swap (#188)
  docs: add links for live previews (#183)
  feat(PoolPage): improve button feedback. reload/clear after create liquidity (#187)
  feat(PoolPage): When set input value, calculate the other input value. Validate if pool ratio is right (#185)
  feat: Save state of pool page (#164)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LuizAsFight LuizAsFight LuizAsFight approved these changes

@pedronauck pedronauck Awaiting requested review from pedronauck

Assignees

@luizstacio luizstacio

Labels
page:swap
Projects
SwaySwap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add user guide states on swap On swap when inverting values its showing insufficient liquidity
2 participants
@luizstacio @LuizAsFight