Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

setup for filling in menu items #9

Merged
merged 6 commits into from Mar 3, 2022
Merged

Conversation

eureka-cpu
Copy link
Contributor

removed hard coded coins and setup the menu to accept the json file

@adlerjohn
Copy link
Contributor

Is this ready for review?

Copy link
Contributor

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, will defer to @luizstacio as the JS expert 😂

Copy link
Member

@luizstacio luizstacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One review, other than that is good! Nice work, looking forward to start refactoring

client/components/Assets.tsx Outdated Show resolved Hide resolved
Copy link
Member

@luizstacio luizstacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@eureka-cpu eureka-cpu merged commit ae893ba into master Mar 3, 2022
@eureka-cpu eureka-cpu deleted the eureka-cpu/menu-function branch March 3, 2022 15:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants