Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refractor(grunt): removed grunt support #70

Merged
merged 1 commit into from
May 5, 2015
Merged

refractor(grunt): removed grunt support #70

merged 1 commit into from
May 5, 2015

Conversation

aniket-fueled
Copy link
Contributor

  • Dropped Support for SaSS and Coffee

saurabh-fueled
saurabh-fueled reviewed May 1, 2015
View reviewed changes
{{cookiecutter.repo_name}}/fabfile.py
@@ -1,4 +1,4 @@
# -*- coding: utf-8 -*-
# -*- coding: utf-8 -*-
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor whitespace issue here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will keep a track of this next time. Already configured by editor as per the requirement.

@saurabh-fueled
Copy link
Contributor

looks good. Please rebase and squash your commit so that it's a single change on top of master.

Apart of all these changes, you also need to remove package.json entry from .bumpversion.cfg file.

Good go merge into master after that.

@aniket-fueled
refractor(grunt): removed grunt support
f41a804 
    - Dropped Support for SaSS and Coffee.
@aniket-fueled
Copy link
Contributor Author

@saurabh-fueled please check.

@saurabh-fueled
Copy link
Contributor

Great! 👍 You can rebase master on top of this branch now and push the master and then delete this branch.

@aniket-fueled aniket-fueled merged commit f41a804 into master May 5, 2015
@aniket-fueled aniket-fueled deleted the remove-grunt branch May 5, 2015 11:53
@aniket-fueled
Copy link
Contributor Author

Deleted remove-grunt branch.

@saurabh-fueled saurabh-fueled mentioned this pull request May 5, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aniket-fueled @saurabh-fueled