Fueled typography #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ada10086
reviewed
Nov 17, 2023
Comment on lines
95
to
104
| struct Typography: Decodable { | ||
| let fontSystem: FontSystem? | ||
| let fontSwift: URL? | ||
| let labelStyleSwift: URL? | ||
| let textStyleSwift: URL? | ||
| let labelStyleSwift: URL? | ||
| let swiftUIFontSwift: URL? | ||
| let generateLabels: Bool | ||
| let labelsDirectory: URL? | ||
| let generateStyles: Bool | ||
| let stylesDirectory: URL? | ||
| let nameStyle: NameStyle | ||
| } |
There was a problem hiding this comment.
ahh good one, its difficult on the project since the default is spaces, so I need to change this for every file I'm working on.
ada10086
reviewed
Nov 17, 2023
Comment on lines
+152
to
+159
| # [optional] Absolute or relative path to swift file where to generate TextStyle extensions for each style (TextStyle extension). | ||
| textStyleSwift: "./Source/UIComponents/TextStyle+extension.swift" | ||
| # [optional] Absolute or relative path to swift file where to export SwiftUI fonts (Font extension). | ||
| swiftUIFontSwift: "./Source/View/Common/Font+extension.swift" | ||
| # Should FigmaExport generate UILabel for each text style (font)? E.g. HeaderLabel, BodyLabel, CaptionLabel | ||
| generateLabels: true | ||
| # Relative or absolute path to directory where to place UILabel for each text style (font) (Requred if generateLabels = true) | ||
| labelsDirectory: "./Source/UIComponents/" | ||
| # Should FigmaExport generate TextStyles for each text style (font)? E.g. Header, Body, Caption | ||
| generateTextStyles: true | ||
| # Relative or absolute path to directory where to place TextStyles for each text style (font) (Required if generateTextStyles = true) | ||
| textStylesDirectory: "./Source/UIComponents/" |
There was a problem hiding this comment.
Should these be in addition to the original labelStyleSwift, generateLabels, and labelsDirectory properties instead of replacing them? Since we are still supporting generating the Label, LabelStyle, LabelStyle+extension files for UIKit
ada10086
reviewed
Nov 17, 2023
Comment on lines
+83
to
+86
| # Should FigmaExport generate TextStyles for each text style (font)? E.g. Header, Body, Caption | ||
| generateStyles: true | ||
| # Relative or absolute path to directory where to place TextStyles for each text style (font) (Required if generateTextStyles = true) | ||
| textStylesDirectory: "./Source/UIComponents/" |
ada10086
reviewed
Nov 17, 2023
Comment on lines
+64
to
+66
| # Choose what font system you want to use SwiftUI or UIKit | ||
| fontSystem: UIKit | ||
| # Path to directory where to place UIFont+extension.swift file required for both SwiftUI and UIKit |
There was a problem hiding this comment.
should we include this in CONFIG.md as well?
ada10086
reviewed
Nov 17, 2023
Comment on lines
+70
to
+73
| # Should FigmaExport generate TextStyles or Labels (based on fontSystem) for each text style (font)? E.g. Header, Body, Caption | ||
| generateStyles: true | ||
| # Relative or absolute path to directory where to place TextStyles or Labels (based on fontSystem) for each text style (font) (Required if generateStyles = true) | ||
| stylesDirectory: "./UIComponents/Source/Typography" |
ada10086
reviewed
Nov 17, 2023
Comment on lines
+68
to
+69
| # Should FigmaExport generate TextStyles for each text style (font)? E.g. Header, Body, Caption | ||
| generateTextStyles: true |
ada10086
reviewed
Nov 17, 2023
Comment on lines
+435
to
438
| - TextStyle.swift.stencil, | ||
| - TextStyle+extension.swift.stencil, | ||
| - Font+extension.swift.stencil | ||
| - UIFont+extension.swift.stencil |
There was a problem hiding this comment.
same question - are we removing support for Label and LabelStyle?
ada10086
reviewed
Nov 17, 2023
| return labelStylesSwiftExtension | ||
| } | ||
|
|
||
| private func makeLabel(textStyles: [TextStyle], labelsDirectory: URL, separateStyles: Bool) throws -> FileContents { |
There was a problem hiding this comment.
Looks like we are generating files for style and style+extension files based on the fontSystem, but if it is UIKit, we are not generating Label.swift anymore?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First steps to support SwiftUI and UIKit for typography into one project