Less intrusive volumecontrol suggestions #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Propsed a change that will add set volume suggesion only if launch text starts with any non-empty prefix of "volume" followed by a number
Fix error
|
Great suggestions. Thanks! |
|
Awesome, thank! |
|
Ricardo, are you going to push a new release? I have deleted my fork and am eagerly waiting PackageControl to bring me the latest and greatest... Thanks, /d |
|
Sorry about that, I had to boot up my Windows installation. Released! https://github.com/Fuhrmann/keypirinha-volumecontrol/releases/tag/1.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VolumeControl is very useful but its capturing of any number I type in the launch box take over higher priority items (it offers volume set suggestion for any text that has numbers in it). I am proposing a change that will add set volume suggestion only if launch text starts with any non-empty prefix of "volume" followed by a number. From the user perspective, instead of typing
30to set volume at 30%, they would need to type something likev30. Typingvs17(for Visual Studio 2017) would no longer suggest setting volume to 17%...Comments: