Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Q-4 Redundant code on L597 of BaseVault #490

Closed
0xdcota opened this issue Apr 24, 2023 · 1 comment · Fixed by #402
Closed

Q-4 Redundant code on L597 of BaseVault #490

0xdcota opened this issue Apr 24, 2023 · 1 comment · Fixed by #402
Assignees
@0xdcota
Labels
Smart Contracts
Milestone
Fuji-v2 MVP

Comments

@0xdcota
Copy link
Contributor

0xdcota commented Apr 24, 2023 •
edited

[Q-4] Redundant code on L597 of BaseVault.sol

Description

BaseVault.sol
L596: function _beforeTokenTransfer(address from, address to, uint256 amount) internal view override {
L597: to; 
    ....

Consider removing this to; since it doesn't do anything.
@0xdcota 0xdcota self-assigned this Apr 24, 2023
@0xdcota 0xdcota added this to the Fuji-v2 MVP milestone Apr 24, 2023
@0xdcota 0xdcota linked a pull request Apr 24, 2023 that will close this issue
Before token transfer blocking liquidations #402
Merged
@0xdcota
Copy link
Contributor Author

0xdcota commented Apr 24, 2023

This issue was open for record purposed only. It was closed previously in PR 402

@0xdcota 0xdcota closed this as completed Apr 24, 2023
@0xdcota 0xdcota mentioned this issue Apr 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xdcota 0xdcota

Labels
Smart Contracts
Projects
None yet
Milestone
Fuji-v2 MVP
Development

Successfully merging a pull request may close this issue.

Before token transfer blocking liquidations Fujicracy/fuji-v2
1 participant
@0xdcota