Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Before token transfer blocking liquidations #402

Conversation

0xdcota
Copy link
Contributor

@0xdcota 0xdcota commented Mar 22, 2023

This pull request addresses H-4 of Macro audit report

@0xdcota 0xdcota added this to the Fuji-v2 MVP milestone Mar 22, 2023
@0xdcota 0xdcota self-assigned this Mar 22, 2023
@0xdcota 0xdcota linked an issue Mar 22, 2023 that may be closed by this pull request
@0xdcota 0xdcota changed the base branch from main to protocol/fix/macro-findings-critical-high March 22, 2023 20:25
@0xdcota 0xdcota marked this pull request as ready for review March 22, 2023 20:25
@0xdcota 0xdcota requested review from brozorec and pedrovalido and removed request for brozorec April 2, 2023 17:08
…l/fix/h-4-before-token-transfer-affects-partial-liquidations
Copy link
Contributor

@pedrovalido pedrovalido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. Approved :)

@pedrovalido pedrovalido merged commit 0779296 into protocol/fix/macro-findings-critical-high Apr 5, 2023
@pedrovalido pedrovalido deleted the protocol/fix/h-4-before-token-transfer-affects-partial-liquidations branch April 5, 2023 12:38
@0xdcota 0xdcota linked an issue Apr 24, 2023 that may be closed by this pull request
Copy link
Collaborator

@0xcuriousapple 0xcuriousapple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Q-4 Redundant code on L597 of BaseVault BeforeTokenTransfer affects partial liquidations
3 participants