Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overriding failed txn in router still an issue #539

Closed
0xdcota opened this issue May 18, 2023 · 0 comments · Fixed by #536
Closed

Overriding failed txn in router still an issue #539

0xdcota opened this issue May 18, 2023 · 0 comments · Fixed by #536
Assignees
@0xdcota
Labels
Bug Something isn't working Smart Contracts
Milestone
Fuji-v2 MVP

Comments

@0xdcota
Copy link
Contributor

0xdcota commented May 18, 2023 •
edited

The issue of front-running a transferId from Connext, and not being able to record the legit failed transaction was identified.

Refer to conversation during review here: #419 (comment)

Therefore, we ideated a system of nonces for consecutive records of the same transferId being recorded.
@0xdcota 0xdcota self-assigned this May 18, 2023
@0xdcota 0xdcota added Bug Something isn't working Smart Contracts labels May 18, 2023
@0xdcota 0xdcota added this to the Fuji-v2 MVP milestone May 18, 2023
@0xdcota 0xdcota linked a pull request May 18, 2023 that will close this issue
Macro post review critical-high #536
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xdcota 0xdcota

Labels
Bug Something isn't working Smart Contracts
Projects
None yet
Milestone
Fuji-v2 MVP
Development

Successfully merging a pull request may close this issue.

Macro post review critical-high Fujicracy/fuji-v2
1 participant
@0xdcota