Overriding transfer handler #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xdcota
changed the base branch from
main
to
protocol/fix/macro-findings-critical-high
…l/fix/h-5-overriding-transfer-handler
|
Everything looks good. Just had to fix some merge conflicts. Ready to merge now |
| @@ -114,8 +131,10 @@ contract ConnextHandler { | |||
| external | |||
| onlyConnextRouter | |||
| { | |||
| _failedTxns[transferId] = | |||
| FailedTxn(transferId, amount, asset, originSender, originDomain, actions, args); | |||
| if (!isTransferIdRecorded(transferId)) { | |||
There was a problem hiding this comment.
Doing this solves overriding vector, but adds a different attacking vector
now anyone can pre-call xBundle with the given transferId and make the legit recordFail revert
we had mentioned this previously as well
https://www.notion.so/0xmacro/Leads-Questions-on-Router-14d2593767a640258c902031573da7c8?pvs=4#c508aacbca3847aca17a1372879ed074
There was a problem hiding this comment.
Hey @abhishekvispute good point, decided to essentially record all attempted transferIds with an increasing nonce.
Please refer to #536.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses H-5 of Macro audit report