Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Borrow: Manage open position #187

Closed
wants to merge 11 commits into from
Closed

Borrow: Manage open position #187

wants to merge 11 commits into from

Conversation

doliG
Copy link
Contributor

@doliG doliG commented Dec 13, 2022

close #41

@doliG
refactor(frontend): prepare edit form
81310ba 
- use position.[token].amount to handle current amount in the vault
- switch the form to edit mode
@doliG
Merge branch 'main' into feature/frontend/manage-position
8e3bf56
@github-actions
Copy link

Please test this PR on: https://v2-staging-187-dot-fuji-306908.ey.r.appspot.com

@doliG doliG changed the title feat: Manage open position Borrow: Manage open position Dec 16, 2022
@brozorec
Copy link
Contributor

@doliG after merging #243 there will be a breaking change in one of the SDK methods.

sdk.previewDepositAndBorrow should get changed to sdk.previews.depositAndBorrow

I think it's used only in one place.

@doliG
Copy link
Contributor Author

doliG commented Feb 5, 2023

Cancelled and closed. Store refacto can be found on #280

@doliG doliG closed this Feb 5, 2023
@ferostabio ferostabio mentioned this pull request Feb 9, 2023
Closed
13 tasks
@brozorec brozorec deleted the feature/frontend/manage-position branch June 21, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Front End
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Borrow: Manage open position
2 participants
@doliG @brozorec