Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix denial of service borrowing vault #376

Merged
merged 20 commits into from Apr 20, 2023
Merged

Fix denial of service borrowing vault #376

merged 20 commits into from Apr 20, 2023

Commits on Mar 15, 2023

  1. test(protocol): denial of service borrowing vault

    @pedrovalido
    pedrovalido committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    0b786e8 View commit details
    Browse the repository at this point in the history

  2. fix(protocol): incorrect contract name

    @pedrovalido
    pedrovalido committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    f1ae94a View commit details
    Browse the repository at this point in the history

  3. test(protocol): denial of service borrowing vault more use cases

    @pedrovalido
    pedrovalido committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    99e3f46 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2023

  1. fix(protocol): ops not counting with previous balances

    @pedrovalido
    pedrovalido committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    ef730bf View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2023

  1. fix(protocol): add correctDebt to counter dos

    @pedrovalido
    pedrovalido committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    c2aed27 View commit details
    Browse the repository at this point in the history

  2. fix(protocol): fix tests, test with correctDebt function

    @pedrovalido
    pedrovalido committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    20c5bb0 View commit details
    Browse the repository at this point in the history

  3. fix(protocol): add pre condition of shares not zero

    @pedrovalido
    pedrovalido committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    ecfacbe View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. fix(protocol): use correctedAmount variable, also check balance of vault

    @pedrovalido
    pedrovalido committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    0ad0438 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2023

  1. fix(protocol): borrowed money stuck in vault

    @pedrovalido
    pedrovalido committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    fa087ea View commit details
    Browse the repository at this point in the history

  2. fix(protocol): check total debt before withdraw

    @pedrovalido
    pedrovalido committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    0fba46a View commit details
    Browse the repository at this point in the history

  3. fix(protocol): add before withdraw hook

    @pedrovalido
    pedrovalido committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    a92048c View commit details
    Browse the repository at this point in the history

  4. test(protocol): check withdraw is paused until correctDebt is called

    @pedrovalido
    pedrovalido committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    33c62dc View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2023

  1. fix(protocol): unpause only when paused

    @pedrovalido
    pedrovalido committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    a087364 View commit details
    Browse the repository at this point in the history

  2. fix(protocol): correct scope of tests

    @pedrovalido
    pedrovalido committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    75c4deb View commit details
    Browse the repository at this point in the history

  3. fix(protocol): remove unused comment

    @pedrovalido
    pedrovalido committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    67c50be View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2023

  1. fix(protocol): remove amount and unpause from correctDebt

    @pedrovalido
    pedrovalido committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    49a5f2e View commit details
    Browse the repository at this point in the history

  2. fix(protocol): remove amount and unpause from correctDebt

    @pedrovalido
    pedrovalido committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    bb24fc6 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2023

  1. chore(protocol): remove compiling warnings and tiny optimizations

    @0xdcota
    0xdcota committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    0fe9d2a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'protocol/fix/macro-findings-critical-high' into protoco… 

    …l/fix/dos-bvault
    @0xdcota
    0xdcota committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    bfc6e66 View commit details
    Browse the repository at this point in the history

  3. chore(protocol): fmt after resolving merge conflicts

    @0xdcota
    0xdcota committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    50cf119 View commit details
    Browse the repository at this point in the history