Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TS definition for extractRawSelector #61

Merged
merged 2 commits into from Mar 11, 2018

Conversation

fpapado
Copy link
Contributor

@fpapado fpapado commented Mar 11, 2018

Proposed changes

RawContent and ExtractorsObj exist under the Purgecss namespace.
They were referenced correctly everywhere except in the extractRawSelector definition.

Without it, using the raw selector would result in the following Typescript error:

node_modules/purgecss/lib/purgecss.d.ts(19,20): error TS2304: Cannot find name 'RawContent'.

19     content: Array<RawContent>,

node_modules/purgecss/lib/purgecss.d.ts(20,24): error TS2304: Cannot find name 'ExtractorsObj'.

20     extractors?: Array<ExtractorsObj>

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

RawContent and ExtractorsObj exist under the Purgecss namespace.
They were referenced correctly everywhere except in the
extractRawSelector definition.
@Ffloriel Ffloriel self-requested a review March 11, 2018 12:06
Copy link
Member

@Ffloriel Ffloriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ffloriel Ffloriel merged commit 6e778a9 into FullHuman:master Mar 11, 2018
@Ffloriel
Copy link
Member

Thanks again for the well explained PRs.

@fpapado
Copy link
Contributor Author

fpapado commented Mar 12, 2018

No worries, thank you for purgecss! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants