Expose 'raw' option for css in types #62
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello again! I thought to split this into a separate one, in case there is any iteration needed.
Proposed changes
The code and tests show that it is possible to specify a 'raw' option for css:
Existing code segment with functionality:
purgecss/src/index.js
Line 124 in 148e2db
Test using it:
https://github.com/FullHuman/purgecss/blob/master/__tests__/purgecssDefault.test.js#L323
However, the type interface does not expose it as an option. Thus, if you're using Typescript or Flow and try to use the raw option for css, an error is raised:
Types of changes
Checklist
Further comments
NOTE:
I went with
RawContent
as the option for consistency with thecontent
interface. This type is technically true, but theextension
field is not used by the code (since it would be css anyway); this is seen inpurgecss/src/index.js
Line 124 in 148e2db
I can change it to an explicit type if needed:
For that matter, I have also not touched the code. Changing the
cssOptions: Array<any>
ingetCssContents
would pair well:None of these changes would be breaking.
Let me know if any of these alternatives sound better, and I'll get to them :)