Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't delete keyframe animations with floats #69

Merged
merged 1 commit into from Mar 20, 2018

Conversation

jsnanigans
Copy link
Member

Proposed changes

fixes Issue: #64
PostCSS thinks that the .9 from 99.9% is a css class selector, this selector then gets treated as any other by purgeCSS but when it finds no selector for .9 its removed.
In this PR the class selector is only treated as a selector if it does not start with a number (^\d)

A side effect is that all other class selectors that start with a number will be kept, but since classes that start with a integer are illegal in CSS this should not be a problem

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Ffloriel Ffloriel self-requested a review March 20, 2018 23:05
Copy link
Member

@Ffloriel Ffloriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks!

@Ffloriel Ffloriel merged commit be5ac0f into master Mar 20, 2018
@Ffloriel Ffloriel deleted the bugfix/keyframes_float_values branch May 16, 2018 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants