Add a step in CONTRIBUTING.md docs #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vnctaing
commented
Jul 30, 2021
| several commands: | ||
|
|
||
| * `npm run dev` will build cjs and es module of all PurgeCSS packages in their `lib` folder and | ||
| watch for changes. | ||
| * `npm run build` will build cjs and es module of all PurgeCSS packages in their `lib` folder. |
There was a problem hiding this comment.
Is there a way to activate the watch mode, I'm not familiar with rollup ?
There was a problem hiding this comment.
There's no watch mode at the moment. The build system was changed when the repository was changed to a monorepo
Ffloriel
approved these changes
Jul 31, 2021
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
As a first-time contributor, I was reading CONTRIBUTING.md, after failling to run tests. I've noticed, that it was missing a tiny step in CONTRIBUTING.md. From there I was able to lint, run test and build the package.