Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 Bug: No space above Controls menu title #296

Closed
3 tasks done
JoshuaKGoldberg opened this issue Aug 19, 2022 · 0 comments 路 Fixed by #324
Closed
3 tasks done

馃悰 Bug: No space above Controls menu title #296

JoshuaKGoldberg opened this issue Aug 19, 2022 · 0 comments 路 Fixed by #324
Assignees
@JoshuaKGoldberg
Labels
package: userwrappr status: accepting prs Go ahead and send a pull request to resolve this issue! type: bug Oh no! Something is broken!
Milestone
ChooseYourFramewo...

Comments

@JoshuaKGoldberg
Copy link
Member

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

The title for an options menu should have a little padding above it inside the hover.

Actual

Controls doesn't:

Screenshot of the Controls hover in ChooseYourFramework

Additional Info

https://github.com/JoshuaKGoldberg/ChooseYourFramework/tree/5bd9afd74922a5319ee07f430ca8758243280870
@JoshuaKGoldberg JoshuaKGoldberg added the type: bug Oh no! Something is broken! label Aug 19, 2022
@JoshuaKGoldberg JoshuaKGoldberg added package: userwrappr status: accepting prs Go ahead and send a pull request to resolve this issue! labels Aug 19, 2022
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Aug 19, 2022
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Aug 22, 2022
Merged
JoshuaKGoldberg added a commit to JoshuaKGoldberg/ChooseYourFramework that referenced this issue Aug 22, 2022
@JoshuaKGoldberg
fix: remove options title hover and correct margins (#9)
11eaad8 
This repo's part of FullScreenShenanigans/EightBittr#186 & FullScreenShenanigans/EightBittr#296.
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Aug 22, 2022
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Aug 22, 2022
@JoshuaKGoldberg
fix: remove options title hover and correct margins (#324)
ec901a5 
Overview
Removes hovering from menu options, so it's only workable for clicks.
Tweaks the hover effect (and makes it used, now!) so it's > ... < before+after pseudo elements.
Tweaks options padding to fix #296 specifically.
PR Checklist

 Fixes #186; fixes #296
 I have run this code to verify it works
 This PR includes unit tests for the code change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
package: userwrappr status: accepting prs Go ahead and send a pull request to resolve this issue! type: bug Oh no! Something is broken!
Projects
None yet
Milestone
ChooseYourFramework Release
Development

Successfully merging a pull request may close this issue.

fix: remove options title hover and correct margins FullScreenShenanigans/EightBittr
1 participant
@JoshuaKGoldberg