Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes history deprecation warning #177

Merged
merged 2 commits into from
May 21, 2019
Merged

fixes history deprecation warning #177

merged 2 commits into from
May 21, 2019

Conversation

fterdal
Copy link
Contributor

@fterdal fterdal commented May 21, 2019

Uses named exports from history to remove deprecation warnings

closes #173

@fterdal fterdal requested review from collin and glebec May 21, 2019 18:25
Copy link
Member

@glebec glebec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glebec
Copy link
Member

glebec commented May 21, 2019

@fterdal: oops, forgot to run prettier on it

Wait, what happened to the automatic prettier script? Is it gone? When did that happen? Why is lint-staged still in there in such a case?

@fterdal
Copy link
Contributor Author

fterdal commented May 21, 2019

@fterdal: oops, forgot to run prettier on it

Wait, what happened to the automatic prettier script? Is it gone? When did that happen? Why is lint-staged still in there in such a case?

I'm...not sure? Maybe it's a Finn editor problem?

@glebec
Copy link
Member

glebec commented May 21, 2019

@fterdal the auto prettify isn't based on editors, it's a Husky pre-commit hook.

Were you working in a repo that had been npm install'd? If the Husky dep isn't installed then of course no git hooks will run on commit. That's the biggest gap in the automatic strategy.

I also see that Ben updated the Husky config in this commit but at first glance it looks ok.

EDIT: nope, it's definitely not working anymore. I will make an issue.

@glebec glebec merged commit b440f29 into master May 21, 2019
@glebec glebec deleted the history-import branch May 21, 2019 19:02
EthanG19 pushed a commit to D3Doritos/AllSign that referenced this pull request Nov 26, 2019
* fixes history deprecation warning

* oops, forgot to run prettier on it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New syntax needed with "history"
3 participants