fix: account is contract #523
Conversation
WalkthroughThe recent updates focus on enhancing the Changes
Sequence Diagram(s) (Beta)sequenceDiagram
participant User
participant BridgeModule
participant EVMKeeper
User ->> BridgeModule: Initiates Bridge Call
BridgeModule ->> EVMKeeper: IsContract(to)
EVMKeeper -->> BridgeModule: true/false
alt Is Contract
BridgeModule ->> EVMKeeper: Proceed with Call
EVMKeeper -->> BridgeModule: Call Success/Failure
else Not a Contract
BridgeModule -->> User: Error: Not a Contract
end
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (6)
- x/crosschain/keeper/bridge_call_in.go (1 hunks)
- x/crosschain/keeper/bridge_call_in_test.go (1 hunks)
- x/crosschain/keeper/bridge_call_refund.go (1 hunks)
- x/crosschain/mock/expected_keepers_mocks.go (2 hunks)
- x/crosschain/types/expected_keepers.go (2 hunks)
- x/evm/keeper/statedb.go (1 hunks)
Additional comments not posted (6)
x/evm/keeper/statedb.go (1)
61-64: The implementation ofIsContractappears correct and efficient.x/crosschain/keeper/bridge_call_refund.go (1)
47-47: Ensure the new contract check integrates well with the rest of the system.Verification successful
The
IsContractcheck withinHandleOutgoingBridgeCallRefundensures that operations are only performed on contract addresses. The usages inabci.goandbridge_call_out.gorely on this check and do not require additional handling for non-contract addresses.
x/crosschain/keeper/abci.gox/crosschain/keeper/bridge_call_out.goScripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify integration of IsContract check in HandleOutgoingBridgeCallRefund. # Test: Search for usage of HandleOutgoingBridgeCallRefund. Expect: Proper handling of non-contract addresses. rg --type go $'HandleOutgoingBridgeCallRefund'Length of output: 604
Script:
#!/bin/bash # Description: Verify handling of non-contract addresses in HandleOutgoingBridgeCallRefund usage. # Inspect usage in abci.go rg --type go --context 5 'HandleOutgoingBridgeCallRefund' x/crosschain/keeper/abci.go # Inspect usage in bridge_call_out.go rg --type go --context 5 'HandleOutgoingBridgeCallRefund' x/crosschain/keeper/bridge_call_out.goLength of output: 884
x/crosschain/keeper/bridge_call_in_test.go (1)
48-48: The addition of theIsContractexpectation in the test is appropriate. Consider adding more comprehensive tests around this functionality.x/crosschain/types/expected_keepers.go (1)
77-77: The update to theEVMKeeperinterface is consistent with the new functionality.x/crosschain/keeper/bridge_call_in.go (1)
83-85: The addition of the contract check inBridgeCallTransferAndCallEvmis crucial for ensuring that operations are only performed on contract addresses.Verification successful
The
IsContractmethod inx/evm/keeper/statedb.gocorrectly identifies contract addresses by checking if the account is not nil and if it is a contract. This ensures that theBridgeCallTransferAndCallEvmfunction only operates on valid contract addresses.
x/evm/keeper/statedb.go:61-64: Implementation ofIsContractmethod.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify integration of IsContract check in BridgeCallTransferAndCallEvm. # Test: Search for usage of BridgeCallTransferAndCallEvm. Expect: Proper handling of non-contract addresses. rg --type go $'BridgeCallTransferAndCallEvm'Length of output: 320
Script:
#!/bin/bash # Description: Locate the implementation of the IsContract method. # Search for the IsContract method in the codebase. ast-grep --lang go --pattern $'func (k Keeper) IsContract(ctx sdk.Context, address sdk.AccAddress) bool { $$$ }'Length of output: 115
Script:
#!/bin/bash # Description: Locate the implementation of the IsContract method with a broader search pattern. # Search for the IsContract method in the codebase. rg --type go 'func.*IsContract'Length of output: 387
Script:
#!/bin/bash # Description: Extract and review the implementation of the IsContract method in x/evm/keeper/statedb.go. # Extract the implementation of the IsContract method. ast-grep --lang go --pattern $'func (k *Keeper) IsContract(ctx sdk.Context, account common.Address) bool { $$$ }' x/evm/keeper/statedb.goLength of output: 414
x/crosschain/mock/expected_keepers_mocks.go (1)
660-664: The implementation ofIsContractinMockEVMKeeperand its recorder appears correctly aligned with GoMock conventions.Also applies to: 668-671
|
mg |
Summary by CodeRabbit
New Features
Bug Fixes
Refactor
GetAccountmethod withIsContractin various components for more accurate contract verification.