fix: not merge duplicate tokens

[zakir-code]

Summary by CodeRabbit

• New Features

  • Improved handling of MsgBridgeCallResultClaim in the Ethereum attestations cleanup process.
  • Optimized ERC20 token creation process for better performance.

• Improvements

  • Enhanced the logic for handling tokens and values in bridge calls, improving efficiency and clarity.

[coderabbitai]

Walkthrough

The updates enhance various components of the application. The CleanEthAttestations function now includes a condition to handle MsgBridgeCallResultClaim. The NewERC20Tokens function optimizes token creation by preallocating slices. In BridgeCall, the logic for handling tokens and values is reordered for better efficiency and clarity.

Changes

File Path	Change Summary
app/upgrades/v7/upgrade.go	Added a condition in CleanEthAttestations to handle MsgBridgeCallResultClaim.
x/crosschain/types/types.go	Optimized NewERC20Tokens by preallocating slices and directly appending ERC20Token instances.
x/evm/precompiles/crosschain/bridge_call.go	Reordered logic in BridgeCall for handling tokens and values, updated coin handling process.

Sequence Diagram(s) (Beta)

sequenceDiagram
    participant User
    participant App
    participant EVM
    participant CrossChainModule
    participant Store

    User->>App: Initiate Bridge Call
    App->>EVM: Handle ERC20 Tokens
    EVM->>App: Return Token Values
    App->>CrossChainModule: Process Tokens
    CrossChainModule->>Store: Update Token Data
    Store->>CrossChainModule: Confirmation
    CrossChainModule->>App: Operation Complete
    App->>User: Bridge Call Successful

Loading

Poem

In code we trust, the changes flow,
Attestations clean, new tokens grow.
With logic clear and slices neat,
Our bridge calls now are quite the feat.
Through bytes and bits, our journey's spun,
Rejoice, dear devs, the work is done!
🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0fb6b36 and fdfefa0.

Files selected for processing (3)

• app/upgrades/v7/upgrade.go (1 hunks)
• x/crosschain/types/types.go (1 hunks)
• x/evm/precompiles/crosschain/bridge_call.go (1 hunks)

Additional comments not posted (5)

x/evm/precompiles/crosschain/bridge_call.go (3)

32-32: Preallocating the coins slice is a good performance optimization.

---

34-39: Correctly handling non-zero values before processing and appending them to the coins slice.

---

41-46: Efficient handling of ERC20 tokens within the loop and appropriate error management.

app/upgrades/v7/upgrade.go (1)

70-71: Updated conditional check correctly handles additional claim types, improving the robustness of the function.

x/crosschain/types/types.go (1)

521-526: Optimization of NewERC20Tokens function by preallocating slice and directly appending tokens enhances performance and reduces complexity.

[nulnut]

mg