-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: transfer sender coins when liquidity is sufficient #578
Conversation
WalkthroughThese changes enhance the cross-chain module by improving the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Keeper
participant Bridge
User->>Keeper: HandlePendingOutgoingBridgeCall(notLiquidCoins)
loop For each bridge coin
Keeper->>Bridge: Transfer bridge coin to external address
Bridge-->>Keeper: Transfer confirmation
end
alt Default Denom in transferLiquidityProviderRewards
Keeper-->>Keeper: Skip conversion
else
Keeper->>Bridge: Convert reward and transfer
Bridge-->>Keeper: Conversion and Transfer confirmations
end
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- x/crosschain/keeper/pending_bridge_call_out.go (2 hunks)
Files not reviewed due to errors (1)
- x/crosschain/keeper/pending_bridge_call_out.go (no review received)
Summary by CodeRabbit
New Features
Improvements