Allow inner joining a kstream to a ktable.

[GreshamDanielStephens]

Add support for inner joins between a kstream and ktable.
This is supported by the java api but not yet exposed in jackdaw.
Moves the existing join method from KTable to KStreamBase to be shared.

Signed-off-by: Daniel Stephens dstephens@greshamtech.com

[cddr]

Sorry I thought I had reviewed this. LGTM. I can resolve the conflict in the Changelog if you wish as it's my fault it has languished for so long.

[zerg000000]

@GreshamDanielStephens any progress on this?

[codecov]

Codecov Report

Merging #175 into master will decrease coverage by 0.41%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
- Coverage   81.22%   80.80%   -0.42%     
==========================================
  Files          41       41              
  Lines        2519     2522       +3     
  Branches      149      149              
==========================================
- Hits         2046     2038       -8     
- Misses        324      335      +11     
  Partials      149      149              

Impacted Files	Coverage Δ
src/jackdaw/streams/configured.clj	69.23% <ø> (ø)
src/jackdaw/streams/interop.clj	80.28% <ø> (ø)
src/jackdaw/streams/protocols.clj	100.00% <ø> (ø)
src/jackdaw/streams.clj	81.74% <75.00%> (-0.52%)	⬇️
src/jackdaw/streams/specs.clj	96.90% <100.00%> (+0.01%)	⬆️
src/jackdaw/serdes/edn2.clj	45.45% <0.00%> (-45.46%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aac78df...507aead. Read the comment docs.

[GreshamDanielStephens]

Ahh that's a shame, I will try and get some more tests written this weekend. Not sure what that edn2 one is or how I caused it :/

[GreshamDanielStephens]

I'm afraid I am just not getting any chance to work on this and won't for the forseeable future so going to close.
FWIW we have this in a util locally:

(defn join
  "This is a case that is supported by the java api but not jackdaw yet.
   Equijoining from a kstream to a ktable."
  [kstream ktable value-joiner-fn this-topic-config other-topic-config]
  (-> kstream
      j/kstream*
      (.join (j/ktable* ktable)
             (jl/value-joiner value-joiner-fn)
             (Joined/with (:key-serde this-topic-config)
                          (:value-serde this-topic-config)
                          (:value-serde other-topic-config)))
      ji/clj-kstream))