-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore the fixtures module to the public interface #266
Conversation
Codecov Report
@@ Coverage Diff @@
## master #266 +/- ##
==========================================
- Coverage 81.22% 80.42% -0.81%
==========================================
Files 41 42 +1
Lines 2594 2753 +159
Branches 153 157 +4
==========================================
+ Hits 2107 2214 +107
- Misses 334 382 +48
- Partials 153 157 +4
Continue to review full report at Codecov.
|
There was a change made to avoid the need of pulling in the admin interface for Kafka (as it hoiks in Scala etc, and makes the base dependencies fairly complex as a result). This involved not putting the |
Thanks, would the best place for that be in the |
Well, the
I think the best place would be the README. |
Most of the test-machine doesn't need the admin-client. And in fact even the bits that do (e.g. creating test topics) can be done using the rest-proxy these days |
This module was part of the public interface of the library, and we depend on it in our integration test suites.
3524968
to
996d732
Compare
This module was part of the public interface of the library, and we depend on it in our integration test suites.