Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an AMD shader crash on Freeplay. #2357

Merged
merged 1 commit into from
May 15, 2024

Conversation

EliteMasterEric
Copy link
Member

Fix a conflict between a shader variable name and a function on some graphics cards.

@EliteMasterEric EliteMasterEric mentioned this pull request May 8, 2024
@prplnorangesoda
Copy link

is "gay" the best name for that variable

@moxie-coder
Copy link

is "gay" the best name for that variable

yes

@EliteMasterEric
Copy link
Member Author

is "gay" the best name for that variable

Absolutely.

@JonnycatMeow
Copy link

W gay shader

@biomseed
Copy link

biomseed commented May 9, 2024

is "gay" the best name for that variable

image

@trayfellow
Copy link

oh my god

@ninjamuffin99
Copy link
Member

closing this PR, as i merged the PR you made internally in our secret repo !

@prplnorangesoda
Copy link

so we NORMAL PEOPLE can't get AMD support until next merge...

@tposejank
Copy link

so we NORMAL PEOPLE can't get AMD support until next merge...

my AMD Apu works perfectly fine idk what the fuss is about .....

@Raltyro
Copy link

Raltyro commented May 9, 2024

closing this PR, as i merged the PR you made internally in our secret repo !

What does he mean by this, is it not completely like open source atm

@biomseed
Copy link

closing this PR, as i merged the PR you made internally in our secret repo !

What does he mean by this, is it not completely like open source atm

secret repo is for future updates i think

@Raltyro
Copy link

Raltyro commented May 10, 2024

It makes me wonder that only this specific pr is atm only in private repo amd users aint eating rn unless they get the build only at this specific commit

@biomseed
Copy link

It makes me wonder that only this specific pr is atm only in private repo amd users aint eating rn unless they get the build only at this specific commit

i'm pretty sure it was merged in the develop branch too so i don't know what's up with that

@ninjamuffin99 ninjamuffin99 reopened this May 15, 2024
@ninjamuffin99 ninjamuffin99 merged commit 37fc849 into develop May 15, 2024
@ninjamuffin99 ninjamuffin99 deleted the bugfix/shader-crash-freeplay branch May 23, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants