Keep the consistency in Conductor #2544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tposejank
approved these changes
May 18, 2024
Sword352
approved these changes
May 18, 2024
|
Good change, avoids "magic numbers" and maintains code readability. |
superpowers04
pushed a commit
to superpowers04/Super-Funkin
that referenced
this pull request
May 18, 2024
Keep the consistency in Conductor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr only changes some
4's inside Conductor to useConstants.STEPS_PER_BEATsincegetBeatTimeInMsuses it but the rest of the functions likegetTimeinStepsandgetStepTimeInMsdoesn't use it, although its a simple pr it probably helps the reader to understand the4inside the functions.