Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX/ENHANCEMENT] Better Freeplay song preview volume + Fix Crash + Remove debug code #2738

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

[BUGFIX/ENHANCEMENT] Better Freeplay song preview volume + Fix Crash + Remove debug code #2738

wants to merge 3 commits into from
+16 −42

Conversation

gamerbross
Copy link
Contributor

@gamerbross gamerbross commented Jun 10, 2024 •
edited
Loading

Here's the list of changes:

  • Reduced Random song preview volume from 80% to 40%, to match the rest of song previews.
  • Properly apply 40% song preview volume when DJ Boyfriend is watching cartoons
  • Fixed a crash when DJ Boyfriend started watching/switched channel cartoons and FlxG.sound.music was null (caused when the song preview is from a mod, and couldn't load FlxPartialSound)
  • Removed a lot of debug code which could do things like (while pressing control): (also didn't allow to move through UI while pressing control)
    • Make DJBF watch cartoons
    • Move DJBF offsets

That's it =)

@gamerbross gamerbross changed the title [BUGFIX/ENHANCEMENT] Better Freeplay song preview volume + Fix Crash [BUGFIX/ENHANCEMENT] Better Freeplay song preview volume + Fix Crash + Remove debug code Jun 11, 2024
@EliteMasterEric EliteMasterEric added status: pending triage Involves a bug which has not been reviewed yet. type: enhancement Provides an enhancement or new feature. status: reviewing internally This PR is under internal review and quality assurance testing polish Issue or PR involves minor polish to the UI or gameplay. and removed status: pending triage Involves a bug which has not been reviewed yet. labels Jun 17, 2024
@JackXson-Real
Copy link

imo the song previews should all be at 80%, 40% is too low.

@gamerbross gamerbross mentioned this pull request Jun 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
polish Issue or PR involves minor polish to the UI or gameplay. status: reviewing internally This PR is under internal review and quality assurance testing type: enhancement Provides an enhancement or new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gamerbross @JackXson-Real @EliteMasterEric