Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Bopper Speed Event #2885

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

[FEATURE] Bopper Speed Event #2885

wants to merge 6 commits into from

Conversation

anysad
Copy link

@anysad anysad commented Jun 22, 2024 •
edited
Loading

  • This PR aims to make players control the speed of each prop in the stage that is a Bopper type.
  • Players can control: characters (boyfriend, girlfriend, opponent/dad) and other Boppers within the stage.

Video Showcase:

showcase.mp4

@EliteMasterEric EliteMasterEric added type: enhancement Provides an enhancement or new feature. status: pending triage The bug or PR has not been reviewed yet. labels Jun 23, 2024
@EliteMasterEric EliteMasterEric changed the base branch from develop to main July 10, 2024 21:39
@EliteMasterEric EliteMasterEric changed the base branch from main to develop July 10, 2024 21:39
EliteMasterEric
EliteMasterEric requested changes Jul 10, 2024
View reviewed changes
Copy link
Member

@EliteMasterEric EliteMasterEric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to say this needed a rebase but I fixed it by fiddling with Git.

Had one idea for a refactor but otherwise I like this.

source/funkin/play/PlayState.hx Outdated Show resolved Hide resolved
source/funkin/play/event/BopperSpeedEvent.hx

var bopperName:String = data.getString('bopper');

var speed:Int = data.getInt('danceEvery') ?? DEFAULT_DANCE_EVERY;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can just leave this as is for now, but in the private branch this has changed to a float which snaps to multiples of 0.25 rather than multiples of 1.

@EliteMasterEric EliteMasterEric added status: needs revision Cannot be approved because it is awaiting some work by the contributor. large A large pull request with more than 100 changes and removed status: pending triage The bug or PR has not been reviewed yet. labels Jul 10, 2024
@EliteMasterEric EliteMasterEric deleted the branch FunkinCrew:develop July 12, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EliteMasterEric EliteMasterEric Awaiting requested review from EliteMasterEric

Assignees
No one assigned
Labels
large A large pull request with more than 100 changes status: needs revision Cannot be approved because it is awaiting some work by the contributor. type: enhancement Provides an enhancement or new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anysad @EliteMasterEric