Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT]: Health Bar Element Adjustments #2905

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

JVNpixels
Copy link

Health Bar Elements zLayer fix

This Pull Request / PR fixes the layering of the healthbar elements because when the players health was low, the score would go behind the icons.

Icon Z-Layer Index

Since the icons would go infront the score text, it would be unreadable, so this commit changes the Z Layer Index for the healthbar, score text, and icons.
Fix zIndex value from 800 to 799, since the healthBar zIndex value was already 800.
@JVNpixels
Copy link
Author

More improvements will come when I know the code for it and when its ready!

@JVNpixels JVNpixels changed the title [ENHANCEMENT]: Health Bar Elements zLayer fix [ENHANCEMENT]: Health Bar Element Adjustments Jun 25, 2024
Scales up the Score Text and re-positions it under the middle of the healthbar.
@CharlesCatYT
Copy link

centered score text???? nah nah i think the score text being on the right is intentional if im just assuming

@JVNpixels
Copy link
Author

Okay, I was planning to add a miss counter thing so I kinda had to move it, but I can just revert it back.

@JVNpixels
Copy link
Author

Yea nvm on the miss counter, too lazy and they prob will say no anyway lol.

@Hundrec
Copy link
Contributor

Hundrec commented Jun 25, 2024

Yea nvm on the miss counter, too lazy and they prob will say no anyway lol.

Yes, please don't add rejected features to pull requests

#2681 (comment)

@JVNpixels
Copy link
Author

If any developer sees this, and does not agree with the centered score text, I will revert it back, just let me know and it will be reverted back to its original state.

@EliteMasterEric EliteMasterEric added status: pending triage Involves a bug which has not been reviewed yet. type: enhancement Provides an enhancement or new feature. labels Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pending triage Involves a bug which has not been reviewed yet. type: enhancement Provides an enhancement or new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants