Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #132

Merged
merged 6 commits into from
Aug 14, 2023
Merged

Update README.md #132

merged 6 commits into from
Aug 14, 2023

Conversation

BombasticTom
Copy link
Contributor

@BombasticTom BombasticTom commented Jul 2, 2023 •
edited
Loading

This pull request aims to make the readme file more consistent. I'll list the proposed changes below:

  • Moved Week 7 and Base Game FLAs to the art section, because I think that it fits the category better
  • Fixed grammar errors, added/improved description for some content.
  • Commented out some stuff (because I wasn't sure if they should be kept or not)
  • Removed duplicates in Chromatic Scale Guides section

@BombasticTom
Copy link
Contributor Author

bruh does the linting really check the comments too

@MarkimusZer0
Copy link
Contributor

Hi Tom!!!
I'd add back the Week 7 Flas tweet to the resource, a couple of the flas listed in the tweet are actually not in the Funkin' repo (surprisingly), like picoSpeaker's fla for example

@BombasticTom
Copy link
Contributor Author

oh sry didn't know i'll do it right away

MarkimusZer0
MarkimusZer0 approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@MarkimusZer0 MarkimusZer0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swaggy

@EliteMasterEric EliteMasterEric merged commit d8d9793 into FunkinCrew:main Aug 14, 2023
1 check passed
@github-actions github-actions bot mentioned this pull request Aug 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EliteMasterEric EliteMasterEric EliteMasterEric approved these changes

@MarkimusZer0 MarkimusZer0 MarkimusZer0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BombasticTom @MarkimusZer0 @EliteMasterEric