New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-1608 Remove deprecated methods from User class #1608
Conversation
…rUtils and UserManager. Move the scoreboard repair logic to the updateScoreboardIfNull(); method.
Use PandaStream which is strongly related to Option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Według mnie w wielu miejscach bardzo naciągane są te Option. Jeżeli już są używane to powinieneś lekko przerobić kod na bardziej funkcyjny, bo robienie if(costamOption.isEmpty()) return
wygląda średnio i ogólnie nie do końca do tego są te option.
plugin/src/main/java/net/dzikoysk/funnyguilds/data/database/DatabaseGuild.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/net/dzikoysk/funnyguilds/feature/hooks/BungeeTabListPlusHook.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/net/dzikoysk/funnyguilds/feature/hooks/MVdWPlaceholderAPIHook.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generalnie już w większości ok, pomijając fakt że ten UserUtils to docelowo też będzie musiał wylecieć później
Remove methods from class User and replace them with methods from UserUtils and UserManager.
Move the scoreboard repair logic to the updateScoreboardIfNull(); method.