Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-1608 Remove deprecated methods from User class #1608

Merged
merged 10 commits into from Sep 8, 2021

Conversation

Rollczi
Copy link
Member

@Rollczi Rollczi commented Aug 24, 2021

Remove methods from class User and replace them with methods from UserUtils and UserManager.
Move the scoreboard repair logic to the updateScoreboardIfNull(); method.

Use PandaStream which is strongly related to Option.
Copy link
Contributor

@CDFN CDFN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Według mnie w wielu miejscach bardzo naciągane są te Option. Jeżeli już są używane to powinieneś lekko przerobić kod na bardziej funkcyjny, bo robienie if(costamOption.isEmpty()) return wygląda średnio i ogólnie nie do końca do tego są te option.

Copy link
Contributor

@dzikoysk dzikoysk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generalnie już w większości ok, pomijając fakt że ten UserUtils to docelowo też będzie musiał wylecieć później

@dzikoysk dzikoysk merged commit 0ad11a1 into master Sep 8, 2021
@dzikoysk dzikoysk deleted the remove-deprecated-methods branch September 8, 2021 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants