Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temperature given in eV instead of keV or K in 3 files. #2857

Closed
OceanNuclear opened this issue Dec 9, 2023 · 0 comments · Fixed by #2891
Closed

Temperature given in eV instead of keV or K in 3 files. #2857

OceanNuclear opened this issue Dec 9, 2023 · 0 comments · Fixed by #2891
Assignees
Labels
fuelcycle Tasks relating to the fuelcycle module 📜 Papercut Papercut bug plasma Tasks relating to the plasma

Comments

@OceanNuclear
Copy link
Contributor

Describe the papercut

When plasma temperature is specified in non-SI unit, it's almost always given as [keV]; except for 3 files:

  • bluemira.codes.process._solver.get_species_data outputs temperature tref in eV.
  • bluemira.plasma_physics.rules_of_thumb.estimate_loop_voltage takes in electron temperature on axis T_e in eV.
  • bluemira.plasma_physics.collisions.spitzer_conductivity takes in electron temperature on axis T_e in eV.

Suggested fix

Convert all of the above from eV to keV instead, using bluemira.base.constants.raw_uc when appropriate.

Other modules affected/ dependencies

No other modules affected.
bluemira.plasma_physics.rules_of_thumb.estimate_loop_voltage uses bluemira.plasma_physics.collisions.spitzer_conductivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fuelcycle Tasks relating to the fuelcycle module 📜 Papercut Papercut bug plasma Tasks relating to the plasma
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant