Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all plasma temperature to be given in unit of keV instead of eV. #2890

Open
OceanNuclear opened this issue Dec 20, 2023 · 0 comments · May be fixed by #2892
Open

Make all plasma temperature to be given in unit of keV instead of eV. #2890

OceanNuclear opened this issue Dec 20, 2023 · 0 comments · May be fixed by #2892
Assignees
Labels
fuelcycle Tasks relating to the fuelcycle module

Comments

@OceanNuclear
Copy link
Contributor

Describe the bug

Following up on issue #2857:
bluemira.codes.process._solver.get_species_data is the only piece of code where temperature is given in units of eV is instead of keV or K.

Expected behaviour

get_species_data returns t_ref in keV instead of eV.

Suggested fix

t_ref_keV = raw_uc(np.array(next(t_ref).data, dtype=float), "eV", "keV")
return t_ref_keV, np.array(next(lz_ref).data, dtype=float), np.array(next(z_av_ref).data, dtype=float)

Additional context

This change would be API-breaking, thus must be approved by all users before merging into the develop branch. @DarioV86

@OceanNuclear OceanNuclear added the fuelcycle Tasks relating to the fuelcycle module label Dec 20, 2023
@OceanNuclear OceanNuclear changed the title Remove the only place where eV is used Make all plasma temperature to be given in unit of keV instead of eV. Dec 20, 2023
@OceanNuclear OceanNuclear self-assigned this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fuelcycle Tasks relating to the fuelcycle module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant