Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: TF_WP #3082

Draft
wants to merge 10 commits into
base: develop
Choose a base branch
from
Draft

WIP: TF_WP #3082

wants to merge 10 commits into from

Conversation

ivanmaione
Copy link
Contributor

Linked Issues

Closes #138

Description

Interface Changes

Checklist

I confirm that I have completed the following checks:

  • Tests run locally and pass pytest tests --reactor
  • Code quality checks run locally and pass pre-commit run --from-ref develop --to-ref HEAD
  • Documentation built locally and checked sphinx-build -W documentation/source documentation/build

@ivanmaione ivanmaione requested a review from a team as a code owner March 9, 2024 07:04
Copy link

sonarcloud bot commented Mar 9, 2024

Quality Gate Passed Quality Gate passed

Issues
132 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
6.1% Duplication on New Code

See analysis details on SonarCloud

@ivanmaione
Copy link
Contributor Author

@CoronelBuendia I cannot rebase the previous branch in the "correct" way. The easy solution was to create a new branch starting from develop. If it is ok, I will close the other PR (just labelled as "obsolete" for the moment). Sorry for the confusion.

@CoronelBuendia CoronelBuendia changed the base branch from develop to feature/new_magnet_module March 10, 2024 19:23
@CoronelBuendia CoronelBuendia requested review from a team as code owners March 10, 2024 19:24
@CoronelBuendia CoronelBuendia changed the base branch from feature/new_magnet_module to develop March 10, 2024 19:24
@je-cook je-cook marked this pull request as draft March 11, 2024 13:18
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 874 lines in your changes missing coverage. Please review.

Project coverage is 72.29%. Comparing base (00e9f87) to head (194efbc).
Report is 44 commits behind head on develop.

Files Patch % Lines
bluemira/magnets/fatigue.py 0.00% 157 Missing ⚠️
bluemira/magnets/conductor.py 0.00% 155 Missing ⚠️
bluemira/magnets/cable.py 0.00% 150 Missing ⚠️
bluemira/magnets/case_tf.py 0.00% 137 Missing ⚠️
bluemira/magnets/materials.py 0.00% 103 Missing ⚠️
bluemira/magnets/strand.py 0.00% 90 Missing ⚠️
bluemira/magnets/winding_pack.py 0.00% 42 Missing ⚠️
bluemira/magnets/utils.py 0.00% 40 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3082      +/-   ##
===========================================
- Coverage    74.27%   72.29%   -1.98%     
===========================================
  Files          242      239       -3     
  Lines        26825    27745     +920     
===========================================
+ Hits         19923    20058     +135     
- Misses        6902     7687     +785     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Apr 15, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@je-cook je-cook force-pushed the develop branch 5 times, most recently from 5a50acb to 7574352 Compare May 15, 2024 08:13
@je-cook je-cook removed request for a team May 29, 2024 15:28
@je-cook je-cook mentioned this pull request Jun 3, 2024
6 tasks
Copy link

sonarcloud bot commented Jun 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link

sonarcloud bot commented Jul 23, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Winding pack design optimisations
1 participant